[Merge] lp:~osomon/webbrowser-app/historyUpdateOnLoadCommitted into lp:webbrowser-app

Riccardo Padovani riccardo at rpadovani.com
Thu Jun 11 20:48:38 UTC 2015


Review: Needs Information

+ browser.historyModel.add(webviewInternal.storedUrl, webviewInternal.storedTitle, icon)

Why this and not 

browser.historyModel.add(webviewInternal.storedUrl, title, icon)

?

I mean, we're updating the database, it's better to do it with last data we have, isn't it?
-- 
https://code.launchpad.net/~osomon/webbrowser-app/historyUpdateOnLoadCommitted/+merge/259361
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~osomon/webbrowser-app/historyUpdateOnLoadCommitted into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list