[Merge] lp:~boiko/telephony-service/dynamic_supported_protocols into lp:telephony-service

Tiago Salem Herrmann tiago.herrmann at canonical.com
Fri Jun 12 18:51:50 UTC 2015


Review: Needs Fixing

The code looks good, but I think it would be good to use a QFileSystemWatcher() to monitor the protocols directory and reload the configuration on demand. The user could install a 3rd party plugin/protocol and wish to use it without restarting the apps. (I suppose dialer/messaging-apps would be notified about the new account, but ProtocolManager would still return the protocol/features are not supported.
What do you think?
-- 
https://code.launchpad.net/~boiko/telephony-service/dynamic_supported_protocols/+merge/261758
Your team Ubuntu Phablet Team is subscribed to branch lp:telephony-service.



More information about the Ubuntu-reviews mailing list