[Merge] lp:~artmello/webbrowser-app/webbrowser-app-bookmark_folders into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Jun 15 19:50:48 UTC 2015


Review: Needs Fixing

238	+                    text: {
239	+                        var ret
240	+                        if (bookmarksFolderColumn.expanded) {
241	+                            ret = "- "
242	+                        } else {
243	+                            ret = "+ "
244	+                        }
245	+
246	+                        if (folder) {
247	+                            return ret + folder
248	+                        } else {
249	+                            return ret + i18n.tr("All Bookmarks")
250	+                        }
251	+                    }

This should be properly internationalized: exotic languages might have different ways of signifying that a section is expanded/collapsed than a minus/plus sign (not to mention RTL languages where the sign would probably be incorrectly placed).
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-bookmark_folders/+merge/260410
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list