[Merge] lp:~sergiusens/goget-ubuntu-touch/assetsGeneric into lp:goget-ubuntu-touch

Sergio Schvezov sergio.schvezov at canonical.com
Wed Jun 24 12:57:20 UTC 2015


On Wed, Jun 24, 2015 at 10:37:55AM -0000, John Lenton wrote:
> Review: Approve
> 
> 1 nit, but +1'ing.
> 
> Diff comments:
> > @@ -182,8 +182,12 @@
> >  		fdtfile = fmt.Sprintf("fdtfile=%s.dtb", platform)
> >  	}
> >  
> > +	templateData := struct{ Fdt, Kernel, Initrd string }{
> > +		fdtfile, kernelFileName, initrdFileName,
> 
> could you use field:value initializers here?

Done

-- 
https://code.launchpad.net/~sergiusens/goget-ubuntu-touch/assetsGeneric/+merge/262706
Your team Ubuntu Phablet Team is subscribed to branch lp:goget-ubuntu-touch.



More information about the Ubuntu-reviews mailing list