[Merge] lp:~mandel/ciborium/remove-formatting-dialog into lp:ciborium

Manuel de la Peña manuel.delapena at canonical.com
Mon Mar 2 12:06:26 UTC 2015


Manuel de la Peña has proposed merging lp:~mandel/ciborium/remove-formatting-dialog into lp:ciborium with lp:~mandel/ciborium/ensure-dirs-created as a prerequisite.

Commit message:
Ensure that more than one format operation can be performed in the ciborium ui.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~mandel/ciborium/remove-formatting-dialog/+merge/251434

Ensure that the second format operation in the ciborium UI can be performed. The main reason for the bug was the fact that go-dbus does gets a deadlock when there is a call to a remove method that emits a signal. They way to solve it is not to wait for errors in an async manner but to use channels instead.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mandel/ciborium/remove-formatting-dialog into lp:ciborium.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 5174 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150302/440a37de/attachment.diff>


More information about the Ubuntu-reviews mailing list