[Merge] lp:~mandel/ciborium/remove-formatting-dialog into lp:ciborium

Wed Mar 4 05:22:39 UTC 2015

Review: Needs Fixing

It's working better but there is still one issue after formatting the sdcard. Basically if you remove and add the sdcard without properly unmounting first, you get 2 notifications saying that it was removed and added successfully. If you do that after formatting the sdcard, you end up getting 3 notifications, with the extra one being an error saying it couldn't really mount the sdcard (while it's actually mounted fine).

The logs:
2015/03/04 02:19:02 dispatcher.go:112: New removal event for path.
2015/03/04 02:19:02 dispatcher.go:119: Removal event is /org/freedesktop/UDisks2/block_devices/mmcblk1 Interfaces: [org.freedesktop.UDisks2.Block org.freedesktop.UDisks2.Filesystem]
2015/03/04 02:19:02 dispatcher.go:155: Processing a remove event from path /org/freedesktop/UDisks2/block_devices/mmcblk1
2015/03/04 02:19:02 dispatcher.go:164: Sending a new general remove event.
2015/03/04 02:19:02 dispatcher.go:167: Sent event /org/freedesktop/UDisks2/block_devices/mmcblk1
2015/03/04 02:19:02 udisks2.go:350: Remove event for /org/freedesktop/UDisks2/block_devices/mmcblk1
2015/03/04 02:19:02 udisks2.go:353: Removing mountpoint /media/phablet/5BBA-4B35
org.freedesktop.UDisks2.Block
org.freedesktop.UDisks2.Filesystem
2015/03/04 02:19:02 udisks2.go:362: Removing device /org/freedesktop/UDisks2/block_devices/mmcblk1
2015/03/04 02:19:02 main.go:243: Path removed /media/phablet/5BBA-4B35
2015/03/04 02:19:02 dispatcher.go:112: New removal event for path.
2015/03/04 02:19:02 dispatcher.go:119: Removal event is /org/freedesktop/UDisks2/drives/SD04G_0x7cee23eb Interfaces: [org.freedesktop.UDisks2.Drive]
2015/03/04 02:19:02 dispatcher.go:155: Processing a remove event from path /org/freedesktop/UDisks2/drives/SD04G_0x7cee23eb
2015/03/04 02:19:02 dispatcher.go:164: Sending a new general remove event.
2015/03/04 02:19:02 dispatcher.go:167: Sent event /org/freedesktop/UDisks2/drives/SD04G_0x7cee23eb
2015/03/04 02:19:02 udisks2.go:350: Remove event for /org/freedesktop/UDisks2/drives/SD04G_0x7cee23eb
2015/03/04 02:19:02 udisks2.go:362: Removing device /org/freedesktop/UDisks2/drives/SD04G_0x7cee23eb
2015/03/04 02:19:02 dispatcher.go:105: New addition event for path /org/freedesktop/UDisks2/jobs/11 map[org.freedesktop.UDisks2.Job:map[Operation:{cleanup} Progress:{0} ProgressValid:{false} Bytes:{0} StartTime:{1425446342825052} Rate:{0} ExpectedEndTime:{0} Objects:{[]} StartedByUID:{0} Cancelable:{true}]]
2015/03/04 02:19:02 dispatcher.go:137: Processing an add event from path /org/freedesktop/UDisks2/jobs/11
2015/03/04 02:19:02 dispatcher.go:140: Sending a new job event.
2015/03/04 02:19:02 dispatcher.go:143: Sent event /org/freedesktop/UDisks2/jobs/11
2015/03/04 02:19:02 jobs.go:56: New event /org/freedesktop/UDisks2/jobs/11 Properties: map[org.freedesktop.UDisks2.Job:map[Rate:{0} ExpectedEndTime:{0} Objects:{[]} StartedByUID:{0} Cancelable:{true} Operation:{cleanup} Progress:{0} ProgressValid:{false} Bytes:{0} StartTime:{1425446342825052}]] Interfaces: []
2015/03/04 02:19:02 jobs.go:106: Creating job for new path /org/freedesktop/UDisks2/jobs/11
2015/03/04 02:19:02 jobs.go:107: New job operation cleanup
2015/03/04 02:19:02 jobs.go:136: Ignoring job event with operation cleanup
2015/03/04 02:19:02 dispatcher.go:112: New removal event for path.
2015/03/04 02:19:02 dispatcher.go:119: Removal event is /org/freedesktop/UDisks2/jobs/11 Interfaces: [org.freedesktop.UDisks2.Job]
2015/03/04 02:19:02 dispatcher.go:155: Processing a remove event from path /org/freedesktop/UDisks2/jobs/11
2015/03/04 02:19:02 dispatcher.go:158: Sending a new remove job event.
2015/03/04 02:19:02 dispatcher.go:161: Sent event /org/freedesktop/UDisks2/jobs/11
2015/03/04 02:19:02 jobs.go:56: New event /org/freedesktop/UDisks2/jobs/11 Properties: map[] Interfaces: [org.freedesktop.UDisks2.Job]
2015/03/04 02:19:02 jobs.go:58: Is removal event
2015/03/04 02:19:02 jobs.go:71: Deal with job event removal /org/freedesktop/UDisks2/jobs/11 [org.freedesktop.UDisks2.Job]
2015/03/04 02:19:02 jobs.go:76: Job completed.
2015/03/04 02:19:02 jobs.go:90: Removed ongoing job for path/org/freedesktop/UDisks2/jobs/11

2015/03/04 02:19:08 dispatcher.go:105: New addition event for path /org/freedesktop/UDisks2/drives/SD04G_0x7cee23eb map[org.freedesktop.UDisks2.Drive:map[Vendor:{} Serial:{0x7cee23eb} MediaChangeDetected:{true} MediaAvailable:{true} Removable:{true} SortKey:{01hotplug/1425446348319421} MediaCompatibility:{[flash_sd]} OpticalBlank:{false} Revision:{} Seat:{seat0} Configuration:{map[]} Media:{flash_sd} Optical:{false} OpticalNumAudioTracks:{0} CanPowerOff:{false} Id:{SD04G-0x7cee23eb} MediaRemovable:{true} Size:{3980394496} SiblingId:{} WWN:{} OpticalNumTracks:{0} OpticalNumDataTracks:{0} RotationRate:{0} ConnectionBus:{sdio} Model:{SD04G} TimeDetected:{1425446348319421} TimeMediaDetected:{1425446348319421} OpticalNumSessions:{0} Ejectable:{false}]]
2015/03/04 02:19:08 dispatcher.go:137: Processing an add event from path /org/freedesktop/UDisks2/drives/SD04G_0x7cee23eb
2015/03/04 02:19:08 dispatcher.go:146: Sending a new general add event.
2015/03/04 02:19:08 dispatcher.go:149: Sent event /org/freedesktop/UDisks2/drives/SD04G_0x7cee23eb
2015/03/04 02:19:08 udisks2.go:321: processAddEvents( /org/freedesktop/UDisks2/drives/SD04G_0x7cee23eb map[org.freedesktop.UDisks2.Drive:map[MediaCompatibility:{[flash_sd]} OpticalBlank:{false} Revision:{} Seat:{seat0} Configuration:{map[]} Media:{flash_sd} Optical:{false} OpticalNumAudioTracks:{0} CanPowerOff:{false} Id:{SD04G-0x7cee23eb} MediaRemovable:{true} Size:{3980394496} SiblingId:{} WWN:{} OpticalNumTracks:{0} OpticalNumDataTracks:{0} RotationRate:{0} ConnectionBus:{sdio} Model:{SD04G} TimeDetected:{1425446348319421} TimeMediaDetected:{1425446348319421} OpticalNumSessions:{0} Ejectable:{false} Vendor:{} Serial:{0x7cee23eb} MediaChangeDetected:{true} MediaAvailable:{true} Removable:{true} SortKey:{01hotplug/1425446348319421}]] [] )
2015/03/04 02:19:08 dispatcher.go:105: New addition event for path /org/freedesktop/UDisks2/block_devices/mmcblk1 map[org.freedesktop.UDisks2.Block:map[DeviceNumber:{45920} MDRaid:{/} MDRaidMember:{/} IdVersion:{FAT32} IdLabel:{} HintPartitionable:{true} HintIgnore:{false} HintIconName:{} HintSymbolicIconName:{} Device:{[47 100 101 118 47 109 109 99 98 108 107 49 0]} Symlinks:{[[47 100 101 118 47 100 105 115 107 47 98 121 45 105 100 47 109 109 99 45 83 68 48 52 71 95 48 120 55 99 101 101 50 51 101 98 0] [47 100 101 118 47 100 105 115 107 47 98 121 45 112 97 116 104 47 112 108 97 116 102 111 114 109 45 109 116 107 45 109 115 100 99 46 49 0] [47 100 101 118 47 100 105 115 107 47 98 121 45 117 117 105 100 47 53 66 66 65 45 52 66 51 53 0]]} Drive:{/org/freedesktop/UDisks2/drives/SD04G_0x7cee23eb} IdUsage:{filesystem} IdUUID:{5BBA-4B35} Configuration:{[]} CryptoBackingDevice:{/} HintAuto:{true} HintName:{} PreferredDevice:{[47 100 101 118 47 109 109 99 98 108 107 49 0]} Id:{by-uuid-5BBA-4B35} Size:{3980394496} IdType:{vfat} ReadOnly:{false} HintSystem:{false}] org.freedesktop.UDisks2.Filesystem:map[MountPoints:{[]}]]
2015/03/04 02:19:08 dispatcher.go:137: Processing an add event from path /org/freedesktop/UDisks2/block_devices/mmcblk1
2015/03/04 02:19:08 dispatcher.go:146: Sending a new general add event.
2015/03/04 02:19:08 dispatcher.go:149: Sent event /org/freedesktop/UDisks2/block_devices/mmcblk1
2015/03/04 02:19:08 udisks2.go:321: processAddEvents( /org/freedesktop/UDisks2/block_devices/mmcblk1 map[org.freedesktop.UDisks2.Block:map[ReadOnly:{false} HintSystem:{false} DeviceNumber:{45920} MDRaid:{/} MDRaidMember:{/} IdVersion:{FAT32} IdLabel:{} HintPartitionable:{true} HintIgnore:{false} HintIconName:{} HintSymbolicIconName:{} Device:{[47 100 101 118 47 109 109 99 98 108 107 49 0]} Symlinks:{[[47 100 101 118 47 100 105 115 107 47 98 121 45 105 100 47 109 109 99 45 83 68 48 52 71 95 48 120 55 99 101 101 50 51 101 98 0] [47 100 101 118 47 100 105 115 107 47 98 121 45 112 97 116 104 47 112 108 97 116 102 111 114 109 45 109 116 107 45 109 115 100 99 46 49 0] [47 100 101 118 47 100 105 115 107 47 98 121 45 117 117 105 100 47 53 66 66 65 45 52 66 51 53 0]]} Drive:{/org/freedesktop/UDisks2/drives/SD04G_0x7cee23eb} IdUsage:{filesystem} IdUUID:{5BBA-4B35} Configuration:{[]} CryptoBackingDevice:{/} HintAuto:{true} HintName:{} PreferredDevice:{[47 100 101 118 47 109 109 99 98 108 107 49 0]} Id:{by-uuid-5BBA-4B35} Size:{3980394496} IdType:{vfat}] org.freedesktop.UDisks2.Filesystem:map[MountPoints:{[]}]] [] )
2015/03/04 02:19:08 udisks2.go:327: Path /org/freedesktop/UDisks2/block_devices/mmcblk1 must be remounted.
2015/03/04 02:19:08 dispatcher.go:105: New addition event for path /org/freedesktop/UDisks2/jobs/12 map[org.freedesktop.UDisks2.Job:map[Operation:{filesystem-mount} Progress:{0} ProgressValid:{false} Bytes:{0} StartTime:{1425446348347347} Rate:{0} ExpectedEndTime:{0} Objects:{[/org/freedesktop/UDisks2/block_devices/mmcblk1]} StartedByUID:{32011} Cancelable:{true}]]
2015/03/04 02:19:08 dispatcher.go:137: Processing an add event from path /org/freedesktop/UDisks2/jobs/12
2015/03/04 02:19:08 dispatcher.go:140: Sending a new job event.
2015/03/04 02:19:08 dispatcher.go:143: Sent event /org/freedesktop/UDisks2/jobs/12
2015/03/04 02:19:08 jobs.go:56: New event /org/freedesktop/UDisks2/jobs/12 Properties: map[org.freedesktop.UDisks2.Job:map[Operation:{filesystem-mount} Progress:{0} ProgressValid:{false} Bytes:{0} StartTime:{1425446348347347} Rate:{0} ExpectedEndTime:{0} Objects:{[/org/freedesktop/UDisks2/block_devices/mmcblk1]} StartedByUID:{32011} Cancelable:{true}]] Interfaces: []
2015/03/04 02:19:08 jobs.go:106: Creating job for new path /org/freedesktop/UDisks2/jobs/12
2015/03/04 02:19:08 jobs.go:107: New job operation filesystem-mount
2015/03/04 02:19:08 jobs.go:136: Ignoring job event with operation filesystem-mount
2015/03/04 02:19:08 dispatcher.go:112: New removal event for path.
2015/03/04 02:19:08 dispatcher.go:119: Removal event is /org/freedesktop/UDisks2/jobs/12 Interfaces: [org.freedesktop.UDisks2.Job]
2015/03/04 02:19:08 dispatcher.go:155: Processing a remove event from path /org/freedesktop/UDisks2/jobs/12
2015/03/04 02:19:08 dispatcher.go:158: Sending a new remove job event.
2015/03/04 02:19:08 dispatcher.go:161: Sent event /org/freedesktop/UDisks2/jobs/12
2015/03/04 02:19:08 jobs.go:56: New event /org/freedesktop/UDisks2/jobs/12 Properties: map[] Interfaces: [org.freedesktop.UDisks2.Job]
2015/03/04 02:19:08 jobs.go:58: Is removal event
2015/03/04 02:19:08 jobs.go:71: Deal with job event removal /org/freedesktop/UDisks2/jobs/12 [org.freedesktop.UDisks2.Job]
2015/03/04 02:19:08 jobs.go:76: Job completed.
2015/03/04 02:19:08 jobs.go:90: Removed ongoing job for path/org/freedesktop/UDisks2/jobs/12
2015/03/04 02:19:08 udisks2.go:131: Mounth path for ' /org/freedesktop/UDisks2/block_devices/mmcblk1 ' set to be /media/phablet/5BBA-4B35
2015/03/04 02:19:08 main.go:243: Mounted /org/freedesktop/UDisks2/block_devices/mmcblk1 as /media/phablet/5BBA-4B35
2015/03/04 02:19:08 main.go:262: createStandardHomeDirs( /media/phablet/5BBA-4B35 )
2015/03/04 02:19:08 main.go:178: Cannot mount /org/freedesktop/UDisks2/block_devices/mmcblk1 due to: org.freedesktop.UDisks2.Error.AlreadyMounted: Device /dev/mmcblk1 is already mounted at `/media/phablet/5BBA-4B35'.

See that it gets an error saying it's already mounted, and it seems that is enough for the error to show up as a dialog.
-- 
https://code.launchpad.net/~mandel/ciborium/remove-formatting-dialog/+merge/251434
Your team Ubuntu Phablet Team is subscribed to branch lp:ciborium.