[Merge] lp:~seb128/telephony-service/dont-unref-gvariant into lp:telephony-service
Sebastien Bacher
seb128 at ubuntu.com
Tue Mar 10 11:09:23 UTC 2015
Sebastien Bacher has proposed merging lp:~seb128/telephony-service/dont-unref-gvariant into lp:telephony-service.
Commit message:
don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by the call to messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue
Requested reviews:
Ubuntu Phablet Team (phablet-team)
Related bugs:
Bug #1427286 in telephony-service (Ubuntu): "g_variant_unref warning displayed when calling back after a missed call "
https://bugs.launchpad.net/ubuntu/+source/telephony-service/+bug/1427286
For more details, see:
https://code.launchpad.net/~seb128/telephony-service/dont-unref-gvariant/+merge/252415
don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by the call to messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~seb128/telephony-service/dont-unref-gvariant into lp:telephony-service.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 406 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150310/f4b615c9/attachment.diff>
More information about the Ubuntu-reviews
mailing list