[Merge] lp:~jhodapp/media-hub/fix-zero-position-while-seeking into lp:media-hub

Jim Hodapp jim.hodapp at canonical.com
Tue Mar 10 20:30:38 UTC 2015


Jim Hodapp has proposed merging lp:~jhodapp/media-hub/fix-zero-position-while-seeking into lp:media-hub with lp:~thomas-voss/media-hub/decouple-player-skeleton-and-implementation as a prerequisite.

Commit message:
* Prevent a 0 position from being reported to the app which happens while seeking. Covers bad behavior that happens from GStreamer. Also expose the about_to_finish signal to the client.
* Enable playback again after manually seeking all the way to EOS. Also only send VideoDimensionsChanged signal only when necessary.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~jhodapp/media-hub/fix-zero-position-while-seeking/+merge/252509

* Prevent a 0 position from being reported to the app which happens while seeking. Covers bad behavior that happens from GStreamer. Also expose the about_to_finish signal to the client.
* Enable playback again after manually seeking all the way to EOS. Also only send VideoDimensionsChanged signal only when necessary.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~jhodapp/media-hub/fix-zero-position-while-seeking into lp:media-hub.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 21327 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150310/a0709c11/attachment.diff>


More information about the Ubuntu-reviews mailing list