[Merge] lp:~rpadovani/webbrowser-app/newTabRefactoring into lp:webbrowser-app

[Olivier Tilloy]

Review: Needs Fixing

Mmm… that does look ugly indeed, and is not scalable, but I understand the problem as you clearly expressed it.

In any case with this approach, there’s one thing that needs fixing:

    } else if (numberOfBookmarks == 1 &&
    […]
    } else if (numberOfTopSites == 1 &&

  you need to check for numberOf… > 0, as we cannot assume that only one bookmark or one topsite was added


Another approach we could take is to not use section delegates, i.e. implement the entire new tab view as a column inside a flickable. That would remove much of the complexity of the code, I think.
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/newTabRefactoring/+merge/247498
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.