[Merge] lp:~mandel/ciborium/disable-unmount-button into lp:ciborium

Manuel de la Peña manuel.delapena at canonical.com
Mon Mar 16 11:18:25 UTC 2015


Manuel de la Peña has proposed merging lp:~mandel/ciborium/disable-unmount-button into lp:ciborium with lp:~mandel/ciborium/keep-track-format-unmount as a prerequisite.

Commit message:
Ensure that we can format and safetly remove 10 times wihtout issues by querying the drives after each action and updating the internal cache. Improve UI to make sure that a format cannot be done when a device is no mounted.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1414731 in ciborium (Ubuntu): "Can't safely remove SD card when a background app has it open"
  https://bugs.launchpad.net/ubuntu/+source/ciborium/+bug/1414731

For more details, see:
https://code.launchpad.net/~mandel/ciborium/disable-unmount-button/+merge/253031

Ensure that we can format and safetly remove 10 times wihtout issues by querying the drives after each action and updating the internal cache. Improve UI to make sure that a format cannot be done when a device is no mounted.

To test this branch please try the following:

* Safetly remove several times. Once a device is removed formatting cannot be done via the ui.
* Remove the device when a confirmation diagram is shown. The app should not crash and the device and the dialog can be closed choosing any option.
* Format works several times.
* Format does not work if an other app uses the device and an message is shown to the user.
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mandel/ciborium/disable-unmount-button into lp:ciborium.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 16456 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150316/6bc92c46/attachment.diff>


More information about the Ubuntu-reviews mailing list