[Merge] lp:~gang65/webbrowser-app/webbrowser-app-keyboard-shortcuts into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Mon Mar 16 15:12:32 UTC 2015
Review: Needs Fixing
I’m seeing a few functional issues:
- Ctrl+L (and Alt+D) doesn’t select the contents of the address bar, it merely gives it focus. I would expect it to select the entire URL for quick and easy edition.
- Pressing Ctrl+H doesn’t work, I get: Browser.qml:693: ReferenceError: toggleActivityView is not defined.
- Looks like there is some focus issue in the app itself: if I open the tabs view then close it by clicking on the "Done" button, keyboard shortcuts don’t work any longer. The issue doesn’t lie in the code you added, but it will need to be fixed as part of this MR to make it fully functional.
--
https://code.launchpad.net/~gang65/webbrowser-app/webbrowser-app-keyboard-shortcuts/+merge/249134
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list