[Merge] lp:~phablet-team/ofono/lp1430700 into lp:~phablet-team/ofono/ubuntu

[Tony Espy]

Review: Needs Fixing

As this change is specific to MTK devices only, my testing was performed on krillin/vivid/#152.

I had two T-Mobile SIMs installed; /ril_0 was a valid PIN-locked SIM, /ril_1 was an expired, unlocked SIM.

The code that was changed involves the MTK device plugin ( mtk.c ) and it's handling of power and SIM mode events/request/reply logic.  As such I performed basic sanity testing of voice and data, and then focused on FlightMode.

Before I could even get to the bug scenario ( Set3g + FM ), I hammered on the indicator-network menu's FM switch a bit to see if I could get it to fail.

I managed to recreate bug #1336715 ( switch items in unity sometimes get out of sync with modem system settings ), an airplane was shown on the panel, however the switch showed FM disabled, but then after about 30s to 1m, the switch flipped back to enabled.

When I tried to reproduce this again, I ran into a situation where the modem wouldn't exit FlightMode.  When I checked the state of the state of the modems, /ril_0 was offline, and /ril_1 was online.

Here's the output of list-modems:

[ /ril_1 ]
    Online = 1
    Lockdown = 0
    Emergency = 0
    Powered = 1
    Revision = MOLY.WR8.W1315.MD.WG.MP.V37.P5, 2014/05/15 11:49
    Manufacturer = Fake Manufacturer
    Features = rat sim 
    Model = Fake Modem Model
    Serial = 354142060413640
    Type = hardware
    Interfaces = org.ofono.RadioSettings org.ofono.SimManager org.ofono.MtkSettings org.ofono.CallVolume org.ofono.VoiceCallManager org.ofono.NetworkTime 
    [ org.ofono.RadioSettings ]
    [ org.ofono.SimManager ]
        PinRequired = none
        FixedDialing = 0
        CardIdentifier = 8901260981853207741
        LockedPins = 
        Present = 1
        SubscriberNumbers = 
        Retries = 
        PreferredLanguages = en 
        BarredDialing = 0
    [ org.ofono.MtkSettings ]
        Has3G = 0
    [ org.ofono.CallVolume ]
        SpeakerVolume = 0
        MicrophoneVolume = 0
        Muted = 0
    [ org.ofono.VoiceCallManager ]
        EmergencyNumbers = 112 911 
    [ org.ofono.NetworkTime ]

[ /ril_0 ]
    Online = 0
    Lockdown = 0
    Emergency = 0
    Powered = 1
    Revision = MOLY.WR8.W1315.MD.WG.MP.V37.P5, 2014/05/15 11:49
    Manufacturer = Fake Manufacturer
    Features = 
    Model = Fake Modem Model
    Serial = 354142060133644
    Type = hardware
    Interfaces = org.ofono.CallVolume org.ofono.VoiceCallManager org.ofono.NetworkTime 
    [ org.ofono.CallVolume ]
        SpeakerVolume = 0
        MicrophoneVolume = 0
        Muted = 0
    [ org.ofono.VoiceCallManager ]
        EmergencyNumbers = 112 911 
    [ org.ofono.NetworkTime ]

urfkill's flight-mode script reports enabled, and the saved-state file shows all devices ( including ALL ) with soft=true, so I don't think this is bug #1430700.

I saved the log file.
-- 
https://code.launchpad.net/~phablet-team/ofono/lp1430700/+merge/253136
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ofono/ubuntu.