[Merge] lp:~osomon/webbrowser-app/bottom-edge into lp:webbrowser-app

Florian Boucault florian.boucault at canonical.com
Fri Mar 20 11:06:55 UTC 2015


Review: Needs Fixing

* tests/autopilot/webbrowser_app/tests/test_tabs.py
- Factor duplicated code to swipe up from the bottom in a common function

* src/app/webbrowser/Browser.qml
- #5d5d5d is UbuntuColors.darkGrey (lots of that value in the codebase)

* src/app/webbrowser/TabChrome.qml
- generally better for components to not define their own width/height but instead implicitWidth/implicitHeight
- "AbstractButton { id: closeButton" should use anchors instead of "height: parent.height"; same for unnamed Item below
- closeButton has a Rectangle without color
- closeButton has no visual feedback when pressing
- Images "tabBackgroundLeft", "tabBackgroundCenter" and "tabBackgroundRight", sources are PNGs without @GU suffix
- "MouseArea.width: parent.width / 2" should probably have a comment
-- 
https://code.launchpad.net/~osomon/webbrowser-app/bottom-edge/+merge/248019
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list