[Merge] lp:~rpadovani/webbrowser-app/settings-page into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Mar 25 10:46:48 UTC 2015


Review: Needs Fixing

browser.allowOpenInBackgroundTab is a string, not a boolean, so the following won’t work as expected:

    control: Switch {
        checked: browser.allowOpenInBackgroundTab
        onClicked: browser.allowOpenInBackgroundTab = checked;
    }

Instead, you’ll need to check that either the value is "true", or it’s "default" and the form factor is desktop.
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/settings-page/+merge/253975
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list