[Merge] lp:~phablet-team/qt-halide/unit-tests into lp:qt-halide
Florian Boucault
florian.boucault at canonical.com
Mon Mar 30 13:55:36 UTC 2015
> > 10) why not use compare or fuzzyCompare (e.g.compare(image.pixel(20, 20),
> > Qt.rgba(255, 0, 0, 255)) instead of creating our own Util.checkColor?
>
> First there is a documentation mismatch: http://doc.qt.io/qt-5/qml-qtqml-
> qt.html#rgba-method and http://doc.qt.io/qt-5/qml-qttest-testcase.html
> #grabImage-method disagree on whether Qt.rgba should use 0-255 or 0.0-1.0
> values to define colors.
>
> And more importantly I tried using compare with Qt.color and it never worked
> reliably, so after wasting several hours I just decided to get done with it
> and use our own function. I will revisit this when I have time to dig a bit
> better, but does not seem like a priority ATM.
Add a comment then and name it consistently with the Qt "compare" function.
--
https://code.launchpad.net/~phablet-team/qt-halide/unit-tests/+merge/254064
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/qt-halide/unit-tests.
More information about the Ubuntu-reviews
mailing list