[Merge] lp:~rpadovani/webbrowser-app/settings-page into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Mar 31 10:21:45 UTC 2015


>  - Instead of having searchEngineContainer and privacyContainer, we could have
> one single subpageContainer, as we will never have two subpages instantiated
> at the same time anyway.

And most importantly, that would allow us to set the visibility of the main settings page accordingly (i.e. hide it whenever there’s a subpage overlaid on top of it).
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/settings-page/+merge/253975
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list