[Merge] lp:~rpadovani/webbrowser-app/settings-page into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Mar 31 11:22:54 UTC 2015


Review: Needs Fixing

 - "clip: true" needs to be set on the flickables, not on the headers.

 - you can simplify the anchors of the header’s label a good deal by setting "anchors.verticalCenter: parent.verticalCenter"

 - instead of trying to set the visibility of the entire page (which won’t work indeed), you can set the visibility of the main header and of the main flickable
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/settings-page/+merge/253975
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list