[Merge] lp:~rpadovani/webbrowser-app/newTabRefactoring into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue May 12 08:16:56 UTC 2015


Review: Needs Fixing

424	+                    Component.onCompleted: {
425	+                        if (model.hidden !== undefined && model.hidden) {
426	+                            height = 0;
427	+                            limit++;
428	+                        }
429	+                    }

The above is not correct. Use the TopSitesModel that filters out hidden entries instead.
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/newTabRefactoring/+merge/247498
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list