[Merge] lp:~dandrader/qtubuntu/improve-resize into lp:qtubuntu

Gerry Boland gerry.boland at canonical.com
Wed May 13 12:12:00 UTC 2015


Review: Needs Fixing

=== modified file 'src/ubuntumirclient/input.cpp'
+/*
+*/
necessary change?

In testing with mir_proving_server, I notice one problem: the surface size QML requests is not the size it gets. Think the geometry.setY() call is problematic now. This used to work before.

Remainder looks good. Am worried that there are 3+ threads (Qt GUI, Qt renderers, Mir input) all interacting with this class tho.
-- 
https://code.launchpad.net/~dandrader/qtubuntu/improve-resize/+merge/258912
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list