[Merge] lp:~artmello/webbrowser-app/webbrowser-app-private_browsing into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Fri May 15 05:52:46 UTC 2015


Review: Needs Fixing

When testing, please monitor the console output for warnings or errors. I’m seeing the following error when launching the app:

    file:///home/osomon/dev/phablet/browser/artmello-private-browsing/src/app/webbrowser/BrowserTab.qml:85: TypeError: Cannot read property 'incognito' of null

This is because the webview might be null, so you’ll need to check that before accessing the incognito property:

    target: webview && webview.incognito ? null : webview
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-private_browsing/+merge/257673
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list