[Merge] lp:~rpadovani/webbrowser-app/remove-404-history into lp:webbrowser-app

[Riccardo Padovani]

Riccardo Padovani has proposed merging lp:~rpadovani/webbrowser-app/remove-404-history into lp:webbrowser-app.

Commit message:
Don't store urls with status different from 2xx in the history

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1244335 in webbrowser-app: "The browser doesn't need to store urls with 404 status in the history"
  https://bugs.launchpad.net/webbrowser-app/+bug/1244335

For more details, see:
https://code.launchpad.net/~rpadovani/webbrowser-app/remove-404-history/+merge/259313

>From the API implementation to the API usage :-)

Now the browser stores in the history only page with status code between 200 and 299 (This class of status codes indicates the action requested by the client was received, understood, accepted and processed successfully)

I don't think it needs to store other codes (also if 5xx could be temporary due server misconfiguration, but the same with 404, so....).

I think all 2xx should be stored, because they are success and could be usefult to consult them in a second moment 
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~rpadovani/webbrowser-app/remove-404-history into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1022 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150516/c4188c82/attachment.diff>