[Merge] lp:~rpadovani/webbrowser-app/newTabRefactoring into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon May 18 10:37:19 UTC 2015


Review: Needs Fixing

In NewTabView.qml, please s/Text/Label/, to ensure consistent theming.

newTabViewLoader is well placed, but there are a few issues with it:
 - it shouldn’t fill the parent, its anchors should be the same as the two other Loaders above it
 - please set its 'asynchronous' property to true, to ensure it doesn’t block rendering at startup
 - the NewTabView component should be loaded only when needed, not always (like it is now)
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/newTabRefactoring/+merge/247498
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list