[Merge] lp:~rpadovani/webbrowser-app/newTabRefactoring into lp:webbrowser-app

[Olivier Tilloy]

Review: Needs Fixing

8	-import Ubuntu.Components.Popups 1.0

Please do not remove that line, it is needed.


44	+            sourceComponent: webviewimpl.incognito ? newPrivateTabViewComponent : newTabViewComponent

This should be browser.incognito, not webviewimpl.incognito.


151	-        function resetFocus() {

This function is still being used, it shouldn’t be removed.


168	-        var tab = tabComponent.createObject(tabContainer, {"initialUrl": url, 'incognito': browser.incognito})
169	+        var tab = tabComponent.createObject(tabContainer, {"initialUrl": url})

This change should be reverted.


177	-            for (var i = 0; i < publicTabsModel.count; ++i) {
178	-                var tab = publicTabsModel.get(i)
179	+            for (var i = 0; i < tabsModel.count; ++i) {
180	+                var tab = tabsModel.get(i)

This change should be reverted.
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/newTabRefactoring/+merge/247498
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.