[Merge] lp:~phablet-team/media-hub/fix-1457129 into lp:media-hub

Thomas Voß thomas.voss at canonical.com
Wed May 27 18:13:12 UTC 2015


Review: Needs Fixing

Please use a std::unique_lock instead of manually try-locking/unlocking the mutex. Would look like:

  std::unique_lock<std::mutex> ul{system_state_cookie_store_guard, std::try_to_lock};
  if (ul.owns_lock())
  {
    // do stuff.
  }

With that, the mutex is always unlocked, even in the case of exceptions.
  
-- 
https://code.launchpad.net/~phablet-team/media-hub/fix-1457129/+merge/260343
Your team Ubuntu Phablet Team is subscribed to branch lp:media-hub.



More information about the Ubuntu-reviews mailing list