[Merge] lp:~rpadovani/webbrowser-app/remove-404-history into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed May 27 18:22:53 UTC 2015


Review: Needs Fixing

151	+        self.assertThat(lambda: history.get_domain_entries(),
152	+                        Eventually(Equals(1)))

This should be lambda: len(history.get_domain_entries())


155	+        expanded_history = history.get_expanded_view()

This fails with the following error:

    autopilot.exceptions.StateNotFoundError: Object not found with name 'QQuickItem' and properties {'objectName': 'expandedHistoryView'}.


157	+        delegates = expanded_history.select_many("UrlDelegate",
158	+                                                 objectName="entriesDelegate")

The above should go after the assertion that verifies that there are eventually 2 entries.


166	+        self.assertThat(delegates[0].url, Equals(self.url))

This line should be removed
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/remove-404-history/+merge/259313
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list