[Merge] lp:~osomon/webbrowser-app/newTabRefactoring-autopilot-tests into lp:webbrowser-app

Riccardo Padovani riccardo at rpadovani.com
Fri May 29 09:39:50 UTC 2015


Review: Needs Fixing

Some things:

-                onHistoryDomainRemoved: browser.historyModel.removeEntriesByDomain(domain)

Why do you remove the possibilty to delete an entire domain? Anyway, if you are sure about this, you should also remove the swype - atm you can swype the domain, but then when you click on the trash icon nothing happens. 


In the ExpandedHistoryView there isn't anymore the multiple selection - I think we should be consistent and have it (or don't have it) both in ExpandedHistoryView and HistoryView 


-- 
https://code.launchpad.net/~osomon/webbrowser-app/newTabRefactoring-autopilot-tests/+merge/260488
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list