[Merge] lp:~osomon/webbrowser-app/missing-import-statements-bookmark-views into lp:webbrowser-app

Ugo Riboni ugo.riboni at canonical.com
Tue Nov 17 16:52:41 UTC 2015


> > Can we factor this and clickItem out into a common test utilities .js
> > file ? They are reimplemented in at least 6 other files now.
> 
> Done, I added a CustomTestCase base class that inherits UbuntuTestCase and has
> extra helper methods.

All good but please change the name to something less vague, like WebbrowserTestCase or something like that.

In swipeToDeleteAndConfirm I don't see the point in having configurable x and dx. Do the flick always from the same point (as it is already the case now) and with a distance that is sure to always trigger the flick (i guess it is proportional to the size of the item, but I haven't checked the code).


-- 
https://code.launchpad.net/~osomon/webbrowser-app/missing-import-statements-bookmark-views/+merge/277366
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list