[Merge] lp:~thomas-voss/location-service/robustify-event-propagation-in-case-of-multiple-providers-running into lp:location-service/15.04
Alberto Mardegan
alberto.mardegan at canonical.com
Wed Nov 18 10:13:12 UTC 2015
Review: Approve
The code looks good to me, but I feel that this makes the logic even more complicated.
I would much rather force all providers to be out of process. This would lead to a simpler design, and might also make it possible to free some memory when the GPS is not in use.
I'm approving this because code-wise it's fine, but if it were for me, I would not merge it.
--
https://code.launchpad.net/~thomas-voss/location-service/robustify-event-propagation-in-case-of-multiple-providers-running/+merge/277789
Your team Ubuntu Phablet Team is subscribed to branch lp:location-service/15.04.
More information about the Ubuntu-reviews
mailing list