[Merge] lp:~artmello/webbrowser-app/webbrowser-app-bookmarks_view into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Oct 14 09:25:41 UTC 2015


Review: Needs Fixing

In BookmarksView.qml and BookmarksViewWide.qml, there are references to 'browser' (calls to browser.openUrlInNewTab). This breaks encapsulation. Please replace this with a signal emission that will be connected to in Browser.qml.
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-bookmarks_view/+merge/270613
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list