[Merge] lp:~uriboni/webbrowser-app/find-in-page-focus into lp:webbrowser-app

[Olivier Tilloy]

> The primary item should be 1gu wide when no icons are visible, not zero as you
> suggest.

The current implementation is not authoritative. The visual spec should be, but I didn’t find any mention of it in there, so we’ll have to make assumptions. 0 sounds more logical to me.


> But in any case it does not seem like such a big simplification to me and i
> personally prefer that each icon has its visible state defined independently.

If all icons should be hidden while in "find in page" mode, then it’s better to hide their parent than each icon individually. This will be future-proof if we ever add new icons to the primary item.
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/find-in-page-focus/+merge/275329
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~uriboni/webbrowser-app/find-in-page-focus into lp:webbrowser-app.