[Merge] lp:~ssweeny/location-service/cleanups into lp:location-service

Scott Sweeny scott.sweeny at canonical.com
Tue Apr 5 21:10:46 UTC 2016


Scott Sweeny has proposed merging lp:~ssweeny/location-service/cleanups into lp:location-service.

Commit message:
Small fixes around provider loading

Requested reviews:
  Thomas Voß (thomas-voss)
  Konrad Zapałowicz (kzapalowicz)

For more details, see:
https://code.launchpad.net/~ssweeny/location-service/cleanups/+merge/291048

A couple of small refactors previously discussed with tvoss:

 * provider loading loop
 * extracting undecorated provider names

Also, clear any stored daemon options before parsing new ones. They were persisting between test runs, which I believe invalidated the cli tests (happily with this fix they still pass).
-- 
Your team Ubuntu Phablet Team is subscribed to branch lp:location-service.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 10929 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160405/10f85b69/attachment.diff>


More information about the Ubuntu-reviews mailing list