[Merge] lp:~barry/apport/lp1566975 into lp:~ubuntu-core-dev/ubuntu/xenial/apport/ubuntu

Barry Warsaw barry at canonical.com
Wed Apr 6 20:18:21 UTC 2016


On Apr 06, 2016, at 08:11 PM, Martin Pitt wrote:

>Err, no, this is wrong. Key names must not contain ':' as ':' is the
>separator between keys and values in RFC822. doc/data-format.tex describes
>the key format, that they must match [0-9a-zA-Z_.-]+.

Well, note the value of 'k' in the assertion failure.  The key was literally

'.proc.driver.nvidia.gpus.0000:01:00.0'

Also note that the assertion doesn't modify the key's value.  If you're
modifying the key somewhere else, you're missing the stripping of ':'.

-- 
https://code.launchpad.net/~barry/apport/lp1566975/+merge/291144
Your team Ubuntu Core Development Team is subscribed to branch lp:~ubuntu-core-dev/ubuntu/xenial/apport/ubuntu.



More information about the Ubuntu-reviews mailing list