[Merge] lp:~barry/apport/lp1566975 into lp:~ubuntu-core-dev/ubuntu/xenial/apport/ubuntu

Barry Warsaw barry at canonical.com
Wed Apr 6 21:02:06 UTC 2016


Just another thought regarding apport itself.  I wonder if an assert is the right thing to do here.  Generally assertions are for ensuring that internal logic is correct.  But what's actually happening in this case is that input from a plugin is invalid.  So probably ValueError would be a better thing to raise explicitly.
-- 
https://code.launchpad.net/~barry/apport/lp1566975/+merge/291144
Your team Ubuntu Core Development Team is subscribed to branch lp:~ubuntu-core-dev/ubuntu/xenial/apport/ubuntu.



More information about the Ubuntu-reviews mailing list