[Merge] lp:~cherojeong/ubuntu-keyboard/korean-layout into lp:ubuntu-keyboard

chero jeong cherojeong at gmail.com
Wed Apr 20 08:36:45 UTC 2016


chero jeong has proposed merging lp:~cherojeong/ubuntu-keyboard/korean-layout into lp:ubuntu-keyboard.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~cherojeong/ubuntu-keyboard/korean-layout/+merge/292348

Hi

Add Korean keyboard layout and predictive text database & spellchecking for hangul.

Q. Are there any related MPs required for this MP to build/function as expected? Please list.
A. No, but this requires hunspell-ko package for spellchecking to work.

Q. Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
A. Yes.

Q. Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
A. Yes, I built the package, installed it and tested it on a device (vega-iron) also 
   on emulator i386 on the rc-proposed/ubuntu channel, release r377
   
   please refer this video for typing hangul keyboard
   (https://www.youtube.com/watch?v=-O1BHlm29l0)

Q. Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-keyboard) on device or emulator?
A. Yes.

Q. If you changed the UI, was the change specified/approved by design?
A. No UI changes, just the addition of a new layout.

Q. If you changed UI labels, did you update the pot file?
A. No UI label changes.

Q.If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
A. TBD

Let me know if there is what I have to do more. 
Thanks

-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~cherojeong/ubuntu-keyboard/korean-layout into lp:ubuntu-keyboard.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 85690 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160420/84d07efb/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list