[Merge] lp:~unity-team/qtubuntu/screen-info-without-dpr into lp:qtubuntu

[Gerry Boland]

> I'm digging into a failure I'm getting with applications when disconnecting an
> external monitor from my test laptop: eglMakeCurrent() fails with
> EGL_BAD_DISPLAY in UbuntuOpenGLContext::makeCurrent() (added a line about it
> in the DGU pad thingy).
> 
> Pushed a couple of innocuous commits to this branch while debugging it, by the
> way.
> 
> Finally, to the main topic of this comment:
> 
> While reading the code I noticed that UbuntuScreen gets an EGLDisplay and
> initializes egl. As if there were an EGLDisplay per screen.
> 
> But as far as I know, it's an EGLDisplay per MirConnection (thus per graphics
> driver/card or even per system [1]).
> 
> So it looks wrong to me that every single UbuntuScreen is doing this sort of
> process-wide initialization. I think UbuntuScreen shouldn't even be holding
> the EGLDisplay. This should all go to some unique,central object.
> 
> Thoughts? Did I miss something?
> 
> [1] - https://www.khronos.org/registry/implementers_guide.html#negldisplay



You are totally right. It's something I've already done in a separate branch:
http://bazaar.launchpad.net/~unity-team/qtubuntu/screen-info2/revision/328
for later merging. I kinda forgot about it in the mean time, and while testing the current code I somehow haven't noticed this crash happening, so let this drop.

I'll propose that fix as a separate branch on top of this. It will need your reviewing. If your change fixes the crash, it won't be critical.
-- 
https://code.launchpad.net/~unity-team/qtubuntu/screen-info-without-dpr/+merge/292410
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.