[Merge] lp:~nick-dedekind/qtubuntu/stagedFullscreen.form-factor into lp:qtubuntu

Bill Filler bill.filler at canonical.com
Thu Feb 4 21:48:23 UTC 2016


Review: Needs Fixing

Working well, just one small issue. The visibility is not reported back to the app correctly. We are using this code in mediaplayer-app:

the media player app shows a "close" button when running on fullscreen: 
visible: (Window.visibility ===  Window.FullScreen)

In staged mode the app is actually fullscreen but the check fails. According to Saviq this needs to be done:
<Saviq> I don't think we're reporting the "real" state back to the app yet, we just need to store the value on flag and restore on !flag
-- 
https://code.launchpad.net/~nick-dedekind/qtubuntu/stagedFullscreen.form-factor/+merge/284979
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list