[Merge] ~kick-d/ubuntu/+source/ntp:logical/4.2.8p4+dfsg-3-ntpdate.if-up into ~ubuntu-server-dev/ubuntu/+source/ntp:debian/sid
Robie Basak
robie.basak at canonical.com
Thu Feb 11 15:05:03 UTC 2016
For reference, we reviewed this in person. The merge mechanics were all correct, but I additionally wanted some additional changelog explanation and extra consideration for all of the delta that has been carried forward through previous merges without much thought, since it all seemed quite large and much of it didn't seem to be necessarily Ubuntu-specific.
Pierre kindly summarised our conversation with the following TODO:
After Robies's review, stuff to do:
Right now:
----------
Remove cron stuf (per mdeslaur irc comment)
Go to original bug into ubuntu regarding the sed rule, add a note in the PPS section about the need to disable the dhcp ntp stuff. (collective decision)
Explanation of pool to server delta. (better explanation in changelog)
Add fPIC confirmed with Marc Deslauriers. (add the fact that it is acknowledge by security team)
Explain the hardening-wrapper better. (deprecated message at build-package time)
Explain update-rcd-update. ( The fact that it is not supported anymore at dpkg --configure install)
Explain drop empty ntp.conf before trusty. (natty timeframe)
Ask caribou to check CVEs. (to double check with fresh eyes)
Rebase the work, and tag the actual with review. (for ease of use)
Later, after debian bug discussions:
-----------------------------------
Openntp and stop / start, bug to debian. (analyse the correctness of this change, drop or initiate debian discussion accordingly)
The -nt /etc/dhcp.conf, same as above.
Enable-debugging to be dropped, bug to debian, drop later.
Depends bison to get included to debian.
What remains is (again, Pierre's summary):
.-Go to original bug into ubuntu regarding the sed rule,
.-Openntp and stop / start, bug to debian. (analyse the correctness of this change, drop or initiate debian discussion accordingly)
.-The -nt /etc/dhcp.conf, same as above.
.-Enable-debugging to be dropped, bug to debian, drop later.
.-Depends bison to get included to debian.
.-Verify dhclient.conf responsible package for eventual ntp-servers request delta. if ubuntu, change README.Debian in this ntp package, else file a bug against Debian.
I did "Go to original bug into ubuntu regarding the sed rule" since I wanted to mention that in the changelog.
--
https://code.launchpad.net/~kick-d/ubuntu/+source/ntp/+git/ntp/+merge/284875
Your team Ubuntu Server Developers is subscribed to branch ~ubuntu-server-dev/ubuntu/+source/ntp:debian/sid.
More information about the Ubuntu-reviews
mailing list