[Merge] ~paelzer/ubuntu/+source/vblade:merge into ~ubuntu-server-dev/ubuntu/+source/vblade:ubuntu/devel
ChristianEhrhardt
christian.ehrhardt at canonical.com
Tue Feb 16 11:51:22 UTC 2016
Thanks,
I'm happy that it looks good to you.
I'm totally fine with the minor changes to the changelog - ack to these.
Also I took the opportunity and added the "update maintainers is implicit
and doesn't have to be in changelog" to our wiki page.
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
On Tue, Feb 16, 2016 at 11:54 AM, Robie Basak <robie.basak at canonical.com>
wrote:
> Review: Approve
>
> Looks good, thanks!
>
> A couple of really minor suggestions to debian/changelog:
> https://git.launchpad.net/~racb/ubuntu/+source/vblade/log/?h=merge
>
> 1. Document why we're causing users inconvenience
> 2. No need to document update-maintainer change (this is implied in all
> Ubuntu merges - I guess this got carried forward all the way from before we
> had settled on this)
>
> If this looks good to you, I'll upload.
> --
>
> https://code.launchpad.net/~paelzer/ubuntu/+source/vblade/+git/vblade/+merge/286138
> You are the owner of ~paelzer/ubuntu/+source/vblade:merge.
>
--
https://code.launchpad.net/~paelzer/ubuntu/+source/vblade/+git/vblade/+merge/286138
Your team Ubuntu Server Developers is subscribed to branch ~ubuntu-server-dev/ubuntu/+source/vblade:ubuntu/devel.
More information about the Ubuntu-reviews
mailing list