[Merge] lp:~vorlon/lxc-android-config/apport-job-cleanup into lp:lxc-android-config

Brian Murray brian at ubuntu.com
Mon Feb 22 17:34:35 UTC 2016


It looks like there is an EVENT missing for the file watch, could that be the cause of the problem?

Diff comments:

> 
> === modified file 'etc/init/apport-config.conf'
> --- etc/init/apport-config.conf	2015-09-30 17:17:07 +0000
> +++ etc/init/apport-config.conf	2016-02-04 07:06:39 +0000
> @@ -1,17 +1,20 @@
>  description "Configure autoreport of crashes for all channels other than stable"
>  
> -start on runlevel [2345]
> +start on starting apport or file FILE=/var/lib/apport/autoreport

The original start on had an event for the FILE e.g. EVENT=create. Could that be what is causing the failure?

>  
>  task
>  
>  script
> -    if [ -f "/var/lib/apport/.apport-config-has-run" ]; then
> -        stop; exit 0
> -    fi
> -    channel="$(cat /etc/system-image/channel.ini | grep channel | awk -F '/' '{print $2}')"
> -    if [ "$channel" = "stable" ]; then
> -        rm /var/lib/apport/autoreport || true
> -    fi
> -    touch /var/lib/apport/.apport-config-has-run
> -    stop; exit 0
> +    if [ ! -f "/var/lib/apport/.apport-config-has-run" ]; then
> +        channel="$(cat /etc/system-image/channel.ini | grep channel | awk -F '/' '{print $2}')"
> +        if [ "$channel" = "stable" ]; then
> +            rm -f /var/lib/apport/autoreport || true
> +        fi
> +        touch /var/lib/apport/.apport-config-has-run
> +    fi
> +    if [ -e /var/lib/apport/autoreport ]; then
> +        start apport || true
> +    else
> +        stop apport || true
> +    fi
>  end script


-- 
https://code.launchpad.net/~vorlon/lxc-android-config/apport-job-cleanup/+merge/285016
Your team Ubuntu Phablet Team is subscribed to branch lp:lxc-android-config.



More information about the Ubuntu-reviews mailing list