[Merge] lp:~ubuntu-mate-dev/livecd-rootfs/ubuntu-mate-base into lp:livecd-rootfs

Dimitri John Ledkov launchpad at surgut.co.uk
Mon Feb 22 19:07:33 UTC 2016


Looks like bare "base" is dropped, see inline comment.

Diff comments:

> === modified file 'BuildLiveCD'
> --- BuildLiveCD	2013-07-23 14:45:15 +0000
> +++ BuildLiveCD	2016-01-29 23:25:21 +0000
> @@ -69,9 +69,9 @@
>      exit 1
>  fi
>  if ([ $# = 0 ] || [ "X$1" = "Xall" ]) && ! $LIVE_BUILD; then
> -    set -- ubuntu kubuntu kubuntu-active edubuntu xubuntu mythbuntu base
> +    set -- ubuntu kubuntu kubuntu-active edubuntu xubuntu xubuntu-base mythbuntu base ubuntu-mate ubuntu-mate-base
>      if [ "$ARCH" = "i386" ]; then
> -        set -- ubuntu ubuntu-dvd ubuntu-lpia ubuntu-netbook kubuntu kubuntu-dvd kubuntu-active edubuntu edubuntu-dvd xubuntu mythbuntu base
> +        set -- ubuntu ubuntu-dvd ubuntu-lpia ubuntu-netbook kubuntu kubuntu-dvd kubuntu-active edubuntu edubuntu-dvd xubuntu xubuntu-base ubuntu-mate ubuntu-mate-base mythbuntu base

Doesn't this line drop the bare "base" ? Is that right? I see "base" is still kept in the default set two lines above. (No clue what "base" is, such looking at the code). And should that "base" be kept last?

>      fi
>  fi
>  


-- 
https://code.launchpad.net/~ubuntu-mate-dev/livecd-rootfs/ubuntu-mate-base/+merge/284432
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~ubuntu-mate-dev/livecd-rootfs/ubuntu-mate-base into lp:livecd-rootfs.



More information about the Ubuntu-reviews mailing list