[Merge] lp:~uriboni/qtubuntu-camera/cameras-info into lp:qtubuntu-camera/staging

Florian Boucault florian.boucault at canonical.com
Wed Feb 24 08:25:33 UTC 2016


Review: Needs Fixing

src/aalcameraserviceplugin.cpp
    return (result != 0) ? QCamera::UnspecifiedPosition :
                           (facing == BACK_FACING_CAMERA_TYPE ? QCamera::BackFace :
                                                                QCamera::FrontFace);

how about using some if blocks to help readability?
-- 
https://code.launchpad.net/~uriboni/qtubuntu-camera/cameras-info/+merge/286283
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu-camera/staging.



More information about the Ubuntu-reviews mailing list