[Merge] lp:~phablet-team/messaging-app/add_thumbnail_to_video_previewer into lp:messaging-app

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Fri Jan 29 12:51:13 UTC 2016


Review: Needs Fixing

Just one comment inline.

Diff comments:

> === modified file 'src/qml/MMS/PreviewerVideo.qml'
> --- src/qml/MMS/PreviewerVideo.qml	2016-01-29 12:43:00 +0000
> +++ src/qml/MMS/PreviewerVideo.qml	2016-01-29 12:43:00 +0000
> @@ -27,6 +27,8 @@
>  Previewer {
>      id: videoPreviewer
>  
> +    property size thumbSize: Qt.size(viewer.width * 1.05, viewer.height * 1.05)

Could you please rename to thumbnailSize?

> +
>      title: i18n.tr("Video Preview")
>      clip: true
>  


-- 
https://code.launchpad.net/~phablet-team/messaging-app/add_thumbnail_to_video_previewer/+merge/284442
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/messaging-app/add-apparmor-profile.



More information about the Ubuntu-reviews mailing list