[Merge] lp:~seb128/update-notifier/systemd into lp:update-notifier

Martin Pitt martin.pitt at ubuntu.com
Wed Jul 20 17:01:29 UTC 2016


Review: Approve

Thanks, looks great now! Just one more nitpick about LP refs in the changelog.

Diff comments:

> === modified file 'debian/changelog'
> --- debian/changelog	2016-07-11 22:05:34 +0000
> +++ debian/changelog	2016-07-20 16:52:23 +0000
> @@ -1,3 +1,19 @@
> +update-notifier (3.171) UNRELEASED; urgency=medium
> +
> +  * debian/update-notifier-cds.conf:
> +    - use a valid variable to get the device name
> +  * debian/systemd, debian/update-notifier.install,links,crash:
> +    - convert the crash, unicast and release jobs to systemd
> +  * debian/systemd/update-notifier-cds.override,
> +    debian/systemd/update-notifier-hp-firmware.override,
> +    debian/update-notifier.install:
> +    - disable the cd-upgrade and hp-firware jobs under systemd, 
> +      they are not important and need more work

refer to the two new LP bugs for tracking those?

> +  * src/avahi.c, src/update.c, src/update-notifier.h,
> +    - use /run instead of /var/run

★★★★★

> +
> + -- Sebastien Bacher <seb128 at ubuntu.com>  Wed, 20 Jul 2016 17:29:30 +0200
> +
>  update-notifier (3.170) yakkety; urgency=medium
>  
>    * data/apt_check.py: use pkg.get_fullname() instead of pkg.name so that


-- 
https://code.launchpad.net/~seb128/update-notifier/systemd/+merge/300634
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~seb128/update-notifier/systemd into lp:update-notifier.



More information about the Ubuntu-reviews mailing list