[Merge] lp:~thomas-voss/net-cpp/bug-fixing-and-features-landing into lp:net-cpp
Gary.Wang
Gary.Wang at canonical.com
Wed Jun 1 02:24:13 UTC 2016
Review: Approve
Thanks tvoss for this MP, it looks good to me.
In this MP, I didn't see pause/resume issue anymore.
I think i should put speed.{limit, duration} into Request::Configuration struct in my MP just as what you do in this MP since we already have this struct there.
I really like the implementation of progress bar, it's quite neat and simple.
Thanks again.
P.S I forget we have sth available in CI labs. :)
--
https://code.launchpad.net/~thomas-voss/net-cpp/bug-fixing-and-features-landing/+merge/296140
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~thomas-voss/net-cpp/bug-fixing-and-features-landing into lp:net-cpp.
More information about the Ubuntu-reviews
mailing list