[Merge] lp:~phablet-team/messaging-framework/notify-group-creation-rejected into lp:messaging-framework
Roberto Mier Escandón
roberto.escandon at canonical.com
Tue Jun 7 21:32:34 UTC 2016
Roberto Mier Escandón has proposed merging lp:~phablet-team/messaging-framework/notify-group-creation-rejected into lp:messaging-framework with lp:~phablet-team/messaging-framework/typing-notification-feature as a prerequisite.
Commit message:
Moved callbacks
- on_group_created()
- on_group_creation_rejected()
to GroupManager. They were previously in a GroupStarter observer but that does not make sense, since is into the textchannel where the callbacks for the result of creating the group in the server should be announced.
Now, if received on_group_creation_rejected() callback, selfHandle() is removed from group members
Requested reviews:
Ubuntu Phablet Team (phablet-team)
For more details, see:
https://code.launchpad.net/~phablet-team/messaging-framework/notify-group-creation-rejected/+merge/296738
Moved callbacks
- on_group_created()
- on_group_creation_rejected()
to GroupManager. They were previously in a GroupStarter observer but that does not make sense, since is into the textchannel where the callbacks for the result of creating the group in the server should be announced.
Now, if received on_group_creation_rejected() callback, selfHandle() is removed from group members
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/messaging-framework/notify-group-creation-rejected into lp:messaging-framework.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 23108 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160607/cc20c9e4/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list