[Merge] lp:~phablet-team/messaging-framework/destroyable_channels into lp:messaging-framework

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Wed Jun 8 16:25:25 UTC 2016


> Nice! I thought this kind of Telepathy implementations would only be included
> in TelepathyQt project, but looks nice this way. I'm thinking about a bunch of
> other implementations that we would need in future.

Yes, at some point we should propose them for upstream, but to make things quicker we can keep them here for now.

> Just a comment below, and a question here:
> Shouldn't this interface belong to a namespace, let's say, "messaging::tp::qt"
> or directly "Tp"?

Good point. Moved them to messaging::qt::tp::interfaces.

> 
> Maybe in future we can shorten them by removing obvious ones

Yep.
-- 
https://code.launchpad.net/~phablet-team/messaging-framework/destroyable_channels/+merge/296745
Your team Ubuntu Phablet Team is subscribed to branch lp:messaging-framework.



More information about the Ubuntu-reviews mailing list