[Merge] lp:~mterry/dialer-app/no-ubuntu-colors into lp:dialer-app

[Michael Terry]

Michael Terry has proposed merging lp:~mterry/dialer-app/no-ubuntu-colors into lp:dialer-app.

Commit message:
Fix colors to use theme colors more consistently.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1581047 in ubuntu-system-settings (Ubuntu): "UbuntuColors considered harmful"
  https://bugs.launchpad.net/ubuntu/+source/ubuntu-system-settings/+bug/1581047

For more details, see:
https://code.launchpad.net/~mterry/dialer-app/no-ubuntu-colors/+merge/297412

See bug 1581047 for full rationale.

Here is a list of potentially noticeable changes:

- Orange buttons are now green.
- Some less important buttons that were orange are now neutral grey: DisableFlightModeDialog cancel, NoDefaultSIMCardDialog no and later, NotificationDialog close, and SetDefaultSIMCardDialog no.
- Call button went from a dark green to theme green.
- Hangup button no longer changes to half-opacity orange when pressed.  Instead it simply changes to half-opacity theme red.  Didn't seem necessary to also change color on top of opacity when pressing.
- KeypadEntry cursor went from orange to blue, the new theme color for text cursors.
- Unrelated to color, but I was right there, so...  SimLockedDialog's Ok button is now spelled OK.  (OK and Okay are words, Ok is not.)

And some less noticeable changes:

- Simply switching hard-coded names to theme equivalents (like darkGrey to backgroundSecondaryColor; same color, new name)
- Small changes like off-brand "red" to theme red
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mterry/dialer-app/no-ubuntu-colors into lp:dialer-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 14621 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20160614/b2e0c3fe/attachment.diff>