[Merge] lp:~tiagosh/dialer-app/add-copy-and-paste into lp:dialer-app

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Tue Mar 8 02:59:33 UTC 2016


Review: Needs Fixing



Diff comments:

> 
> === modified file 'tests/autopilot/dialer_app/tests/test_dialer.py'
> --- tests/autopilot/dialer_app/tests/test_dialer.py	2014-06-20 13:26:49 +0000
> +++ tests/autopilot/dialer_app/tests/test_dialer.py	2016-03-03 18:33:05 +0000
> @@ -52,3 +52,26 @@
>          dialer_page = self.main_view.dialer_page
>  
>          self.assertThat(dialer_page.visible, Eventually(Equals(True)))
> +
> +    def test_dialer_copy_and_paste(self):
> +        keypad_entry = self.main_view.dialer_page._get_keypad_entry()
> +        keypad_keys = self.main_view.dialer_page._get_keypad_keys()
> +        for key in keypad_keys:
> +            self.main_view.dialer_page.click_keypad_button(key)
> +
> +        value = keypad_entry.value
> +        self.main_view.dialer_page.trigger_copy_and_paste()
> +        self.main_view.dialer_page.trigger_select_all()
> +        self.main_view.dialer_page.trigger_cut()
> +
> +        self.assertThat(
> +            keypad_entry.value,
> +            Eventually(Equals(""))
> +        )
> +
> +        self.main_view.dialer_page.trigger_copy_and_paste()

I think you need to self.main_view.dialer_page.trigger_paste() before comparing the values, no?

> +
> +        self.assertThat(
> +            keypad_entry.value,
> +            Eventually(Equals(value))
> +        )


-- 
https://code.launchpad.net/~tiagosh/dialer-app/add-copy-and-paste/+merge/287845
Your team Ubuntu Phablet Team is subscribed to branch lp:dialer-app.



More information about the Ubuntu-reviews mailing list