[Merge] lp:~thomas-voss/location-service/enable-dual-landings-take-2 into lp:location-service

[Thomas Voß]

> Hey! Thanks for submitting this branch, would be nice to dual-land this.
> 
> So there's one small thing that's 'Needs Fixing' and two 'Needs Information'.
> 
> Needs Fixing:
> You would need to include the changelog entry for this landing in the
> changelog diff here since this file has been touched. Train in such cases
> won't add the changelog entry based on the commit message in this case. Be
> sure to leave it as UNRELEASED.
> 

Should be fixed.

> Needs Information:
> Small thing: I was wondering, I see we have an explicit -dbg package. Aren't
> those auto-generated on uploads? Just wondering if in this case we need one
> explicitly.

It's an artifact originating in the times when the train did not offer dbgsym packages for silos.
However, I would rather prefer to keep the packaging changes introduced in this branch limited and follow up with an MP that removes the package.

> The second one is, of course, any chance for ABI compliance checking + some
> shlibs? ;) I suppose we export some symbols here, would be nice to have the
> some checks here for dual landing. Not sure how far Michi went with
> implementing abigail [1] in his ABI checking - I see there are some commits in
> their staging branch.
> 

I would love to have abigail integrated and I'm happy to file and assign a critical bug for tracking the issue. That being said, I would think we shouldn't block on the lack of symbol checking. It was missing before this branch and the changes do not make the situation worse ;-)

> [1] https://sourceware.org/libabigail/
-- 
https://code.launchpad.net/~thomas-voss/location-service/enable-dual-landings-take-2/+merge/288746
Your team Ubuntu Phablet Team is subscribed to branch lp:location-service.