[Merge] lp:~abreu-alexandre/webbrowser-app/command-line-option-external-urls-in-overlay into lp:webbrowser-app

[Alberto Mardegan]

Review: Needs Information

Looks good, just one question inline.

Diff comments:

> 
> === modified file 'src/app/webcontainer/WebViewImplOxide.qml'
> --- src/app/webcontainer/WebViewImplOxide.qml	2016-02-10 12:55:31 +0000
> +++ src/app/webcontainer/WebViewImplOxide.qml	2016-02-29 14:31:43 +0000
> @@ -220,10 +221,15 @@
>                 disposition === Oxide.NavigationRequest.DispositionNewForegroundTab;
>      }
>  
> -    function openUrlExternally(url) {
> -        webview.openExternalUrlTriggered(url)
> -        if (! webview.blockOpenExternalUrls) {
> -            Qt.openUrlExternally(url)
> +    function openUrlExternally(url, request) {
> +        if (openExternalUrlInOverlay && request) {
> +            popupController.createPopupViewForUrl(overlayViewsParent, url, true, context)

Why do you need "request" here? Did you want to use createPopupViewForRequest() instead?

> +            return
> +        } else {
> +            webview.openExternalUrlTriggered(url)
> +            if (! webview.blockOpenExternalUrls) {
> +                Qt.openUrlExternally(url)
> +            }
>          }
>      }
>  


-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/command-line-option-external-urls-in-overlay/+merge/287395
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.